Return-Path: 
 <notifications-return-30432-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4083717C55
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Fri, 22 May 2015 18:00:18 +0000 (UTC)
Received: (qmail 49584 invoked by uid 500); 22 May 2015 18:00:18 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 49540 invoked by uid 500); 22 May 2015 18:00:18 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 49525 invoked by uid 99); 22 May 2015 18:00:18 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2015 18:00:18 +0000
Date: Fri, 22 May 2015 18:00:18 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12831599.1432181746000.12079.1432317618055@Atlassian.JIRA>
In-Reply-To: <JIRA.12831599.1432181746000@Atlassian.JIRA>
References: <JIRA.12831599.1432181746000@Atlassian.JIRA>
 <JIRA.12831599.1432181746201@arcas>
Subject: [jira] [Commented] (ACCUMULO-3840) Refactor OpTimer so that it does
 not use log4j logger.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/ACCUMULO-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556521#comment-14556521 ] 

Josh Elser commented on ACCUMULO-3840:
--------------------------------------

Thanks for putting up a patch, Ed.

{code}
private static enum Timers {
  ELAPSED
}
{code}

This ends up duplicated all over the place. The only place I see the enum being used well is in BulkImporter, where it actually does result in a nice simplification. Maybe it would make sense to consolidate the following case in a class that extends our StopWatch to simplify client code.

{code}
public class SingleStopWatch extends StopWatch<Timers> {
  private static enum Timers {
    ELAPSED
  }

  public void synchronized start() {
    super.start(ELAPSED);
  }

  public void synchronized stop() {
    super.stop(ELAPSED);
  }
}
{code}

I'd love to be working towards have the client API instrumented well so that it's really clear to just look at a client application and know what took long on the client (complements the recent HTrace work on the server -- we can hopefully get to a full picture of client+server timings).

I have some other irritations about our StopWatch class (synchronization should be removed and mark the class as not threadsafe, should try to avoid System.currentTimeMillis), but those don't need to be addressed now.

Thoughts?

> Refactor OpTimer so that it does not use log4j logger.
> ------------------------------------------------------
>
>                 Key: ACCUMULO-3840
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3840
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 1.6.2, 1.7.0
>            Reporter: Ed Coleman
>            Assignee: Ed Coleman
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3840.patch
>
>
> OpTimer currently uses log4j specific classes. OpTimer and the callers can be modified so that log4j dependencies are not required.
> The evaluation of timer consolidation raised in ACCUMULO-3329 can still be performed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)