accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Created] (ACCUMULO-3856) ProxyServer.update fails silently if batchwriter doesn't exist
Date Wed, 27 May 2015 19:07:21 GMT
Josh Elser created ACCUMULO-3856:

             Summary: ProxyServer.update fails silently if batchwriter doesn't exist
                 Key: ACCUMULO-3856
             Project: Accumulo
          Issue Type: Bug
          Components: proxy
            Reporter: Josh Elser
            Priority: Critical
             Fix For: 1.6.3, 1.8.0, 1.7.1

Inspecting ProxyServer, saw the following:

  public void update(String writer, Map<ByteBuffer,List<ColumnUpdate>> cells)
throws TException {
    try {
      BatchWriterPlusException bwpe = getWriter(writer);
      addCellsToWriter(cells, bwpe);
    } catch (UnknownWriter e) {
      // just drop it, this is a oneway thrift call and throwing a TException seems to make
all subsequent thrift calls fail

This means that calls to update which fail to get a BatchWriter (for whatever reason) will
silently fail and appear to the user to have written data successfully. This is horrible.

I'm not sure what the comment means either. I'm not sure why throwing a TException from the
server would invalidate the connection, but perhaps I'm just ignorant of some finer details.

This message was sent by Atlassian JIRA

View raw message