accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-3854) [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure
Date Wed, 27 May 2015 17:08:18 GMT
Josh Elser created ACCUMULO-3854:
------------------------------------

             Summary: [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure
                 Key: ACCUMULO-3854
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3854
             Project: Accumulo
          Issue Type: Bug
    Affects Versions: 1.7.0, 1.6.2, 1.6.1, 1.6.0, 1.5.2, 1.5.1, 1.5.0
            Reporter: Josh Elser
            Priority: Minor
             Fix For: 1.8.0, 1.7.1


Noticed this one playing around with ACCUMULO-3853

If the type of {{sendQueue}} is switched to the concrete ConcurrentLinkedQueue instead of
AbstractQueue, findbugs will catch this as an error because we synchronize on a concurrent
data structure.

{code}
-  protected final AbstractQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
+  protected final ConcurrentLinkedQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
{code}

Should trigger some findbugs warnings from the Maven build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message