accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3841) accumulo-native continues if `make` fails and causes NativeMapIT failure
Date Thu, 21 May 2015 16:52:18 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554645#comment-14554645
] 

Christopher Tubbs commented on ACCUMULO-3841:
---------------------------------------------

What you propose might be possible. However, it's not just NativeMapIT which requires the
native maps to be built. Many other tests probably rely on timing which only works reliably
if the native maps are enabled (I suppose we could adjust these, as we find them).

The dependency in the test pom on the native maps artifact would have to be moved to a profile
(perhaps activated by the presence of the native maps). I'm not 100% sure the extent of this
impact on our tests.

Personally, I think it's reasonable to consider it a build requirement to have `make`, `g++`,
and `javah` installed in order to build Accumulo.

I am curious why the build proceeded at all if `make` failed, though. Was this in Jenkins
or some other system where maven was executed with `--fail-at-end`? Otherwise, I'm not sure
why accumulo-native would continue to be built.

> accumulo-native continues if `make` fails and causes NativeMapIT failure
> ------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3841
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3841
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build, test
>            Reporter: Josh Elser
>            Priority: Minor
>             Fix For: 1.8.0, 1.7.1
>
>
> On a system that didn't have a C++ compiler installed, ran the ITs.
> NativeMapIT failed because libaccumulo.so couldn't be loaded, because it was never built!
> Some thoughts:
> * It would be nice to not fail the build when we're running integration-tests and we
fail to build the native map
> * NativeMapIT could JUnit assume itself off when libaccumulo.so can't be loaded from
the expected location
> Thoughts [~ctubbsii]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message