accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ed Coleman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3840) Refactor OpTimer so that it does not use log4j logger.
Date Fri, 22 May 2015 18:24:17 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556556#comment-14556556
] 

Ed Coleman commented on ACCUMULO-3840:
--------------------------------------

That's a great idea and I'll work on it.  I think there are a few other things that can go
into the sub-class to help clean things up.

One thing that I did notice is that OpTimer is only ever used at TRACE level (except for a
test case) - even in a place or two where the comments say that for performance, logging should
not be done. - That would seem to indicate that tracing would not be appropriate at that level
and may for all of OpTimer usages.

The reason that I didn't go further in this round with tracing is so that it will be done
with consideration and consistently. The thing to do would be to get a feeling for where we
need to measure client operations and then add them sort of top / down.

Are you thinking nanoTime instead of currentTimeMillis?  I thought about borrowing the Guava
StopWatch / Ticker to approach to allow us to swap time sources, but then figured that it
would be superseded by tracing and that nanos where unnecessary with the precision that we
need and the fact that these are hardly ever used.


> Refactor OpTimer so that it does not use log4j logger.
> ------------------------------------------------------
>
>                 Key: ACCUMULO-3840
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3840
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 1.6.2, 1.7.0
>            Reporter: Ed Coleman
>            Assignee: Ed Coleman
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3840.patch
>
>
> OpTimer currently uses log4j specific classes. OpTimer and the callers can be modified
so that log4j dependencies are not required.
> The evaluation of timer consolidation raised in ACCUMULO-3329 can still be performed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message