accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ed Coleman (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-3840) Refactor OpTimer so that it does not use log4j logger.
Date Fri, 22 May 2015 17:37:18 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ed Coleman updated ACCUMULO-3840:
---------------------------------
    Status: Patch Available  (was: Open)

The patch file uses StopWatch instead of OpTimer.  A few notes about this approach

OpTimer - deprecated.  Not used in Accumulo code base if this patch is used - not sure if
anyone would be using it.

OpTimer prints thread id and an op id.  There were two places where op id looks like it was
anything but 0. Kept thread id and dropped op id from log statement except where op id could
have a value > 0 - in those cases print both.  Kept thread id to remain similar with statements
that would be logged.

[~elserj] - if you could take a quick look, you seem most familiar with this code right now
and I would like your opinion if this is a viable approach or if you think something else
would be more appropriate.

> Refactor OpTimer so that it does not use log4j logger.
> ------------------------------------------------------
>
>                 Key: ACCUMULO-3840
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3840
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 1.7.0, 1.6.2
>            Reporter: Ed Coleman
>            Assignee: Ed Coleman
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3840.patch
>
>
> OpTimer currently uses log4j specific classes. OpTimer and the callers can be modified
so that log4j dependencies are not required.
> The evaluation of timer consolidation raised in ACCUMULO-3329 can still be performed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message