accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3771) Configure automatic java code style formatting
Date Mon, 04 May 2015 22:18:06 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527453#comment-14527453
] 

ASF GitHub Bot commented on ACCUMULO-3771:
------------------------------------------

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/35#issuecomment-98866799
  
    IIRC, there was an issue with Eclipse itself not adhering to the checkstyle. Not knocking
what you've done -- my hunch was that it might be the maven plugin itself not doing what it's
told to do.


> Configure automatic java code style formatting 
> -----------------------------------------------
>
>                 Key: ACCUMULO-3771
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3771
>             Project: Accumulo
>          Issue Type: Task
>    Affects Versions: 1.8.0
>            Reporter: Mike Walch
>            Assignee: Mike Walch
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> I configured automatic Java style formatting for Fluo in [FLUO-479|https://github.com/fluo-io/fluo/issues/479].
 This was done using the maven-java-formatter-plugin which formats all Java classes on every
build according to a specified Eclipse style configuration file.  This has worked well for
Fluo so Christopher Tubbs asked me to create a patch for Accumulo.  
> This patch will be composed of two commits.  The first commit will be the configuration
for the plugin.   The second commit will be all changes to Java classes after the plugin is
run.
> While auto-formatting has been a nice addition for Fluo, it does require a lot of changes
to the code initially.  If you are unhappy with this change, feel free to object...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message