accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3771) Configure automatic java code style formatting
Date Mon, 04 May 2015 21:44:07 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527375#comment-14527375
] 

ASF GitHub Bot commented on ACCUMULO-3771:
------------------------------------------

GitHub user mikewalch opened a pull request:

    https://github.com/apache/accumulo/pull/35

    ACCUMULO-3771 Configure automatic java code style formatting

    Pull request for [ACCUMULO-3771](https://issues.apache.org/jira/browse/ACCUMULO-3771)
    
    To make code review easier, you should add `&w=0` to your URL to remove any white
space differences.  This should bring down the files changed to only 88 files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikewalch/accumulo autoformat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 4b69fba5604ecef44339d90aebb22c6b7bc6a88a
Author: Mike Walch <mwalch@gmail.com>
Date:   2015-05-04T19:31:36Z

    ACCUMULO-3771 Configure automatic Java code style formatting
    
    * Added maven-java-formatter-plugin to POM files

commit 098d3e1a84562c4bc10ce95fc083599cdb8afb0d
Author: Mike Walch <mwalch@gmail.com>
Date:   2015-05-04T21:26:53Z

    ACCUMULO-3771 Configure automatic Java code style formatting
    
    * Built Accumulo which ran maven-java-formatter-plugin for first time

----


> Configure automatic java code style formatting 
> -----------------------------------------------
>
>                 Key: ACCUMULO-3771
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3771
>             Project: Accumulo
>          Issue Type: Task
>    Affects Versions: 1.8.0
>            Reporter: Mike Walch
>            Assignee: Mike Walch
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> I configured automatic Java style formatting for Fluo in [FLUO-479|https://github.com/fluo-io/fluo/issues/479].
 This was done using the maven-java-formatter-plugin which formats all Java classes on every
build according to a specified Eclipse style configuration file.  This has worked well for
Fluo so Christopher Tubbs asked me to create a patch for Accumulo.  
> This patch will be composed of two commits.  The first commit will be the configuration
for the plugin.   The second commit will be all changes to Java classes after the plugin is
run.
> While auto-formatting has been a nice addition for Fluo, it does require a lot of changes
to the code initially.  If you are unhappy with this change, feel free to object...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message