accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3771) Configure automatic java code style formatting
Date Tue, 05 May 2015 15:56:01 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528707#comment-14528707
] 

ASF GitHub Bot commented on ACCUMULO-3771:
------------------------------------------

Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/35#issuecomment-99123399
  
    > One thing I'd like to see, though (for the purposes of a review) is just the pom
change
    
    The PR has two commits.  Commit 4b69fba has just pom changes.  Is that what you are looking
for?
    
    > It adds a trailing space to indent empty javadoc lines.
    
    Would you happen to know if this if fixed in later versions of Eclipse?  This formatter
plugin currently [relies on Eclipse 3.8.1](https://github.com/mblanchette/maven-java-formatter-plugin/blob/0.4/pom.xml#L66)
code to do the formatting.
    



> Configure automatic java code style formatting 
> -----------------------------------------------
>
>                 Key: ACCUMULO-3771
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3771
>             Project: Accumulo
>          Issue Type: Task
>    Affects Versions: 1.8.0
>            Reporter: Mike Walch
>            Assignee: Mike Walch
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> I configured automatic Java style formatting for Fluo in [FLUO-479|https://github.com/fluo-io/fluo/issues/479].
 This was done using the maven-java-formatter-plugin which formats all Java classes on every
build according to a specified Eclipse style configuration file.  This has worked well for
Fluo so Christopher Tubbs asked me to create a patch for Accumulo.  
> This patch will be composed of two commits.  The first commit will be the configuration
for the plugin.   The second commit will be all changes to Java classes after the plugin is
run.
> While auto-formatting has been a nice addition for Fluo, it does require a lot of changes
to the code initially.  If you are unhappy with this change, feel free to object...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message