accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3771) Configure automatic java code style formatting
Date Wed, 06 May 2015 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530766#comment-14530766
] 

ASF GitHub Bot commented on ACCUMULO-3771:
------------------------------------------

Github user mikewalch commented on the pull request:

    https://github.com/apache/accumulo/pull/35#issuecomment-99519198
  
    I just pushed an updated PR with following changes:
    
    * Modified the configuration of the maven-java-formatter-plugin in `pom.xml` to use a
newer version (3.10) of the eclipse.jdt.core.  This reduced but did not eliminate the number
of trailing whitespace changes.   The number of files changed by the formatter was reduced
from the 550 to 170.
    * I agree with Christoper about the formatter.  It mostly removes whitespace.  The only
place where it adds whitespace is in block comments.  To get checkstyle work, I modified the
"Trailing whitespace" checkstyle rule ignore whitespace after an asterisk `*`.
    * Excluded thrift and proto buffer files in the formatter plugin configuration
    
    I reviewed all of the files that were changed after running the formatter.  While they
look good to me, feel free to comment on any formatting that should remain and I can add `//
@formatter:off` comments to those sections of the code.


> Configure automatic java code style formatting 
> -----------------------------------------------
>
>                 Key: ACCUMULO-3771
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3771
>             Project: Accumulo
>          Issue Type: Task
>    Affects Versions: 1.8.0
>            Reporter: Mike Walch
>            Assignee: Mike Walch
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> I configured automatic Java style formatting for Fluo in [FLUO-479|https://github.com/fluo-io/fluo/issues/479].
 This was done using the maven-java-formatter-plugin which formats all Java classes on every
build according to a specified Eclipse style configuration file.  This has worked well for
Fluo so Christopher Tubbs asked me to create a patch for Accumulo.  
> This patch will be composed of two commits.  The first commit will be the configuration
for the plugin.   The second commit will be all changes to Java classes after the plugin is
run.
> While auto-formatting has been a nice addition for Fluo, it does require a lot of changes
to the code initially.  If you are unhappy with this change, feel free to object...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message