accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-3604) connector.instanceOperations().setSystemProperty(String,String) returns silently for non-changeable ZK Property's
Date Thu, 21 May 2015 22:44:17 GMT


Josh Elser commented on ACCUMULO-3604:

bq. No. The behavior when one attempts to modify an unchangeable property is presently undefined.

I don't think I agree with you. Since when would attempting to change an unchangeable property
not be an error condition? What are you basing your assertion that this is undefined on?

bq. Since this method lacks such documentation, the behavior is undefined.

Oh, ok. Now I understand where you're coming from. Since it's not explicitly noted, you assume
it's undefined. I tend to be on the side that I _know_ a property is unmodifiable and thus
I can extrapolate that it should be an error.

bq. But I never said that. I said I bumped it because it wasn't clear to me

Ok, I interpreted your comment of "it's not entirely clear to me that this is a bug" to mean
that you don't think it should go into bugfix lines. More discussion is wonderful. Master
[~kturner]: do you have an opinion from a public API standpoint?

> connector.instanceOperations().setSystemProperty(String,String) returns silently for
non-changeable ZK Property's
> -----------------------------------------------------------------------------------------------------------------
>                 Key: ACCUMULO-3604
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2
>            Reporter: Josh Elser
>            Assignee: Jeffrey S Schwartz
>              Labels: newbie, summit2015
>             Fix For: 1.8.0
>         Attachments: ACCUMULO-3604.patch
> Only a subset of the configuration {{Property}}'s in Accumulo are modifiable via ZooKeeper
(defined by {{Property.isValidZooProperty}}).
> {{connector.instanceOperations().setProperty(String,String)}} updates the provided property
name with the given value in ZooKeeper. The thing that is never mentioned is that only a subset
of the properties in Accumulo are allowed to be overriden in ZooKeeper. Furthermore, the user
receives no indication that their call failed.
> The Javadoc on {{setSystemProperty(String,String)}} should be updated to inform the users
that only some properties can be changed by this method, and some information should be returned
back to the user to let them know that their call did not succeed (likely an Exception).

This message was sent by Atlassian JIRA

View raw message