accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3000) Allow use of existing ZK service in MiniAccumuloCluster
Date Wed, 13 May 2015 03:34:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541260#comment-14541260
] 

ASF GitHub Bot commented on ACCUMULO-3000:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r30200397
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
---
    @@ -75,6 +75,7 @@
       private static final String NUM_T_SERVERS_PROP = "numTServers";
       private static final String DIRECTORY_PROP = "directory";
       private static final String INSTANCE_NAME_PROP = "instanceName";
    +  private static final String EXISTING_ZOO_KEEPERS_PROP = "existingZooKeepers";
    --- End diff --
    
    Did we already address the addition here? MiniAccumuloRunner is also public API (like
MiniAccumuloCluster). Seems odd to add it here. I don't think we have a good way to hide it
though (like the MiniAccumuloClusterImpl), so maybe it's ok?


> Allow use of existing ZK service in MiniAccumuloCluster
> -------------------------------------------------------
>
>                 Key: ACCUMULO-3000
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3000
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: mini
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Josh Elser
>            Assignee: Trent Nadeau
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8.0
>
>
> A test harness may have already started ZooKeeper for other testing. MiniAccumuloCluster
could use that same ZooKepeer instance, instead of creating its own, but it is currently not
possible given what MAC does now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message