accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-3000) Allow use of existing ZK service in MiniAccumuloCluster
Date Wed, 13 May 2015 20:05:00 GMT


ASF GitHub Bot commented on ACCUMULO-3000:

Github user ctubbsii commented on a diff in the pull request:
    --- Diff: .gitignore ---
    @@ -23,3 +23,4 @@
    --- End diff --
    The reason is that when you switch branches in git, it leaves behind ignored files. So,
we've stopped doing global ignores, and instead have been doing "rooted" ignores (I don't
know if that's the official term... it's just what I'm calling ignore expressions beginning
with "/"). That way, when you switch branches, you can see what was left behind (most frequently,
"target/" directories from previous builds for modules which exist in another branch, but
not the current one). This allows you to do more targeted `git clean` executions with `git
clean -fd` instead of needing to do `git clean -fdx`.
    If we do global ignores (with the prefixing "/"), some maven plugins (assembly, rat, etc.)
may treat those extra files as source files, because they don't exist in a current module's
"target/" directory (other source directories could, after all, also use the name "target").
    Keeping the `.gitignore` files rooted to each module helps us avoid ignoring files which
could be problematic if ignored globally.

> Allow use of existing ZK service in MiniAccumuloCluster
> -------------------------------------------------------
>                 Key: ACCUMULO-3000
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: mini
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Josh Elser
>            Assignee: Trent Nadeau
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8.0
> A test harness may have already started ZooKeeper for other testing. MiniAccumuloCluster
could use that same ZooKepeer instance, instead of creating its own, but it is currently not
possible given what MAC does now.

This message was sent by Atlassian JIRA

View raw message