accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <>
Subject [jira] [Updated] (ACCUMULO-2877) CachedConfiguration.setInstance never used outside class
Date Tue, 26 May 2015 21:44:19 GMT


Christopher Tubbs updated ACCUMULO-2877:
    Fix Version/s:     (was: 1.7.1)
                       (was: 1.6.3)
                       (was: 1.5.3)

For what it's worth, the patch does not apply cleanly (due to whitespace differences). After
fixing the whitespace issues, I noticed the patch also breaks compilation, because the getter
was using the setter method which this patch removes.

Since this isn't public API and doesn't actually address any bugs, I think we could probably
mark this closed as "Won't Fix". However, it would also be reasonable to mark the setter "private",
or inline the method so it doesn't cause any problems later with somebody using it unexpectedly.
That could be applied to master since it wouldn't address any bugs in previous versions (if
you want to do that, feel free to provide a patch which does that, [~ansonl], otherwise, I'll
go ahead make it happen so we can close this). In the meantime, I've dropped those other versions
from the fixVersion set.

It also appears there was some discussion about improvements to the API where an HDFS Configuration
object could be passed it. I'd recommend that be converted to its own issue, if anybody is
inclined to pursue it.

> CachedConfiguration.setInstance never used outside class
> --------------------------------------------------------
>                 Key: ACCUMULO-2877
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Anson Liu
>            Priority: Trivial
>              Labels: newbie, summit2014
>             Fix For: 1.8.0
>         Attachments: ACCUMULO-2877.patch, ACCUMULO-2877.patch
> The method {{CachedConfiguration.setInstance()}} is a public static method but is never
used outside the class. It should be hidden or removed.

This message was sent by Atlassian JIRA

View raw message