Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Tue, 14 Apr 2015 00:37:12 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12820588.1428947339000.76815.1428971832183@Atlassian.JIRA>
In-Reply-To: <JIRA.12820588.1428947339000@Atlassian.JIRA>
References: <JIRA.12820588.1428947339000@Atlassian.JIRA>
 <JIRA.12820588.1428947339620@arcas>
Subject: [jira] [Commented] (ACCUMULO-3723) TabletServerBatchReaderIterator
 can eat OOM exceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493367#comment-14493367 ] 

Josh Elser commented on ACCUMULO-3723:
--------------------------------------

Along the same lines, I think we catch Error in at least one place which is a big no-no as well. IIRC, the Error-catch was related to noticing *when* an OOME happens, but it might be better removed than any benefit it provides (especially with the {code}-XX:OnOutOfMemoryError="${ACCUMULO_KILL_CMD:-kill -9 %p}"{code} we have in bin/accumulo now)

> TabletServerBatchReaderIterator can eat OOM exceptions
> ------------------------------------------------------
>
>                 Key: ACCUMULO-3723
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3723
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.0
>            Reporter: John Vines
>
> Currently in run() it catches Throwable and does no effort to force up catastrophic errors. In general we shouldn't be catching Throwable unless we know exactly what we're doing.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)