Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE10617EBA for ; Tue, 14 Apr 2015 18:51:27 +0000 (UTC) Received: (qmail 92111 invoked by uid 500); 14 Apr 2015 18:51:12 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 92074 invoked by uid 500); 14 Apr 2015 18:51:12 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 92050 invoked by uid 99); 14 Apr 2015 18:51:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2015 18:51:12 +0000 Date: Tue, 14 Apr 2015 18:51:12 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-3608) Restore backwards binary compatibility with version 1.6.z MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494584#comment-14494584 ] Josh Elser commented on ACCUMULO-3608: -------------------------------------- The following all appear to be deprecated in 1.6.0. The classes were moved to an impl in 1.7.0 (as it was unintended to be public API). I believe all of these are fine. {noformat} accumulo-core-1.6.2.jar, ConnectorInfo.class package org.apache.accumulo.core.client.mapreduce.lib.util ConfiguratorBase.ConnectorInfo.valueOf ( String name ) [static] : ConfiguratorBase.ConnectorInfo ConfiguratorBase.ConnectorInfo.values ( ) [static] : ConfiguratorBase.ConnectorInfo[ ] accumulo-core-1.6.2.jar, Features.class package org.apache.accumulo.core.client.mapreduce.lib.util InputConfigurator.Features.valueOf ( String name ) [static] : InputConfigurator.Features InputConfigurator.Features.values ( ) [static] : InputConfigurator.Features[ ] OutputConfigurator.Features.valueOf ( String name ) [static] : OutputConfigurator.Features OutputConfigurator.Features.values ( ) [static] : OutputConfigurator.Features[ ] accumulo-core-1.6.2.jar, FileOutputConfigurator.class package org.apache.accumulo.core.client.mapreduce.lib.util FileOutputConfigurator.FileOutputConfigurator ( ) FileOutputConfigurator.getAccumuloConfiguration ( Class implementingClass, org.apache.hadoop.conf.Configuration conf ) [static] : org.apache.accumulo.core.conf.AccumuloConfiguration *DEPRECATED* FileOutputConfigurator.isSupportedAccumuloProperty ( org.apache.accumulo.core.conf.Property property ) [static] : Boolean *DEPRECATED* FileOutputConfigurator.setCompressionType ( Class implementingClass, org.apache.hadoop.conf.Configuration conf, String compressionType ) [static] : void *DEPRECATED* FileOutputConfigurator.setDataBlockSize ( Class implementingClass, org.apache.hadoop.conf.Configuration conf, long dataBlockSize ) [static] : void *DEPRECATED* FileOutputConfigurator.setFileBlockSize ( Class implementingClass, org.apache.hadoop.conf.Configuration conf, long fileBlockSize ) [static] : void *DEPRECATED* FileOutputConfigurator.setIndexBlockSize ( Class implementingClass, org.apache.hadoop.conf.Configuration conf, long indexBlockSize ) [static] : void *DEPRECATED* FileOutputConfigurator.setReplication ( Class implementingClass, org.apache.hadoop.conf.Configuration conf, int replication ) [static] : void *DEPRECATED* accumulo-core-1.6.2.jar, GeneralOpts.class package org.apache.accumulo.core.client.mapreduce.lib.util ConfiguratorBase.GeneralOpts.valueOf ( String name ) [static] : ConfiguratorBase.GeneralOpts ConfiguratorBase.GeneralOpts.values ( ) [static] : ConfiguratorBase.GeneralOpts[ ] accumulo-core-1.6.2.jar, InstanceOperationsImpl.class package org.apache.accumulo.core.client.admin InstanceOperationsImpl.InstanceOperationsImpl ( org.apache.accumulo.core.client.Instance instance, org.apache.accumulo.core.security.thrift.TCredentials credentials ) accumulo-core-1.6.2.jar, InstanceOpts.class package org.apache.accumulo.core.client.mapreduce.lib.util ConfiguratorBase.InstanceOpts.valueOf ( String name ) [static] : ConfiguratorBase.InstanceOpts ConfiguratorBase.InstanceOpts.values ( ) [static] : ConfiguratorBase.InstanceOpts[ ] accumulo-core-1.6.2.jar, MockTabletLocator.class package org.apache.accumulo.core.client.mock MockTabletLocator.binMutations ( java.util.List mutations, java.util.Map> binnedMutations, java.util.List failures, org.apache.accumulo.core.security.thrift.TCredentials credentials ) : void MockTabletLocator.binRanges ( java.util.List ranges, java.util.Map>> binnedRanges, org.apache.accumulo.core.security.thrift.TCredentials credentials ) : java.util.List MockTabletLocator.locateTablet ( org.apache.hadoop.io.Text row, boolean skipRow, boolean retry, org.apache.accumulo.core.security.thrift.TCredentials credentials ) : org.apache.accumulo.core.client.impl.TabletLocator.TabletLocation MockTabletLocator.MockTabletLocator ( ) accumulo-core-1.6.2.jar, SecurityOperationsImpl.class package org.apache.accumulo.core.client.admin SecurityOperationsImpl.SecurityOperationsImpl ( org.apache.accumulo.core.client.Instance instance, org.apache.accumulo.core.security.Credentials credentials ) SecurityOperationsImpl.SecurityOperationsImpl ( org.apache.accumulo.core.client.Instance instance, org.apache.accumulo.core.security.thrift.TCredentials credentials ) accumulo-core-1.6.2.jar, SecurityOperationsImpl.class package org.apache.accumulo.core.client.admin SecurityOperationsImpl.SecurityOperationsImpl ( org.apache.accumulo.core.client.Instance instance, org.apache.accumulo.core.security.Credentials credentials ) SecurityOperationsImpl.SecurityOperationsImpl ( org.apache.accumulo.core.client.Instance instance, org.apache.accumulo.core.security.thrift.TCredentials credentials ) accumulo-core-1.6.2.jar, WriteOpts.class package org.apache.accumulo.core.client.mapreduce.lib.util OutputConfigurator.WriteOpts.valueOf ( String name ) [static] : OutputConfigurator.WriteOpts OutputConfigurator.WriteOpts.values ( ) [static] : OutputConfigurator.WriteOpts[ ] {noformat} The moving of MockShell is a breakage: moved from core.client.mock.MockShell to shell.mock w/o a deprecation cycle. I believe we want to do the same thing as we did for the above MapReduce classes (restore+deprecate and remove in 1.8/next) {noformat} accumulo-core-1.6.2.jar, MockShell.class package org.apache.accumulo.core.client.mock MockShell.config ( String... args ) : boolean MockShell.makeCommands ( String... commands ) [static] : java.io.ByteArrayInputStream MockShell.MockShell ( java.io.InputStream in, java.io.OutputStream out ) MockShell.MockShell ( java.io.InputStream in, java.io.Writer out ) *DEPRECATED* MockShell.setConsoleInputStream ( java.io.InputStream in ) : void MockShell.setConsoleWriter ( java.io.OutputStream out ) : void MockShell.setConsoleWriter ( java.io.Writer out ) : void *DEPRECATED* MockShell.setInstance ( org.apache.accumulo.core.util.shell.ShellOptionsJC options ) : void MockShell.setInstance ( org.apache.commons.cli.CommandLine cl ) : void *DEPRECATED* MockShell.start ( ) : int {noformat} > Restore backwards binary compatibility with version 1.6.z > --------------------------------------------------------- > > Key: ACCUMULO-3608 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3608 > Project: Accumulo > Issue Type: Bug > Affects Versions: 1.7.0 > Reporter: Sean Busbey > Priority: Blocker > Fix For: 1.7.0 > > Attachments: 1.6.2_to_1.7.0_compat_report.html, 1.7.0_to_1.6.2_compat_report.html, compat_report.html > > > We need to ensure that a check for binary backwards compatibility passes when comparing 1.6.z to current master, since it is only a minor version bump. > {quote} > That means new classes, interfaces,methods, enum members, etc are all fine. All of the things labelled as HIGH severity in the binary compatibility report are definitely a problem. They're mostly classes and methods that were removed. > The end goal should be a report like the one Corey got for 1.6.1 -> 1.6.2. We don't need the reciprocal report to be compatible because minor versions need not be forward compatible. > Problems in the source compatibility report are worth reviewing, but things that only show up there shouldn't be a blocker. > {quote} > There are instructions for running the compatibility checker in test/compat/japi-compliance/README -- This message was sent by Atlassian JIRA (v6.3.4#6332)