Return-Path: 
 <notifications-return-29487-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 100BB1796C
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Tue, 21 Apr 2015 17:51:01 +0000 (UTC)
Received: (qmail 68534 invoked by uid 500); 21 Apr 2015 17:51:01 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 68502 invoked by uid 500); 21 Apr 2015 17:51:01 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 68489 invoked by uid 99); 21 Apr 2015 17:51:00 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 17:51:00 +0000
Date: Tue, 21 Apr 2015 17:51:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12727737.1405535472000.64307.1429638660833@Atlassian.JIRA>
In-Reply-To: <JIRA.12727737.1405535472000@Atlassian.JIRA>
References: <JIRA.12727737.1405535472000@Atlassian.JIRA>
 <JIRA.12727737.1405535472832@arcas>
Subject: [jira] [Commented] (ACCUMULO-3000) Allow use of existing ZK service
 in MiniAccumuloCluster
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/ACCUMULO-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505365#comment-14505365 ] 

ASF GitHub Bot commented on ACCUMULO-3000:
------------------------------------------

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r28803912
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java ---
    @@ -108,6 +108,19 @@ public MiniAccumuloConfig setZooKeeperStartupTime(long zooKeeperStartupTime) {
       }
     
       /**
    +   * Configure an existing ZooKeeper instance to use. Calling this method is optional. If not set, a new ZooKeeper instance is created.
    +   *
    +   * @param existingZooKeepers
    +   *          Connection string for a already-running ZooKeeper instance
    +   *
    +   * @since 1.7.0
    +   */
    +  public MiniAccumuloConfig setExistingZooKeepers(String existingZooKeepers) {
    --- End diff --
    
    Could have the following (this allows setter to be more strict about its input).
    
    ```java
       public void clearExistingZookeepers()
      /**
       * throws IllegalArgExcep if null or empty string
       */
       public void setExistingZookeepers(String ezk);
       public Optional<String> getExistingZookeepers();
    ```


> Allow use of existing ZK service in MiniAccumuloCluster
> -------------------------------------------------------
>
>                 Key: ACCUMULO-3000
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3000
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: mini
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Josh Elser
>            Assignee: Trent Nadeau
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8.0
>
>
> A test harness may have already started ZooKeeper for other testing. MiniAccumuloCluster could use that same ZooKepeer instance, instead of creating its own, but it is currently not possible given what MAC does now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)