Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB293178FE for ; Thu, 9 Apr 2015 00:34:12 +0000 (UTC) Received: (qmail 90950 invoked by uid 500); 9 Apr 2015 00:34:12 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 90914 invoked by uid 500); 9 Apr 2015 00:34:12 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 90896 invoked by uid 99); 9 Apr 2015 00:34:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2015 00:34:12 +0000 Date: Thu, 9 Apr 2015 00:34:12 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ACCUMULO-2131) while statement used as if statement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Tubbs updated ACCUMULO-2131: ---------------------------------------- Fix Version/s: (was: 1.7.1) (was: 1.8.0) 1.7.0 > while statement used as if statement > ------------------------------------ > > Key: ACCUMULO-2131 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2131 > Project: Accumulo > Issue Type: Bug > Components: tserver > Reporter: Eric Newton > Assignee: Bob Thorman > Priority: Trivial > Labels: newbie > Fix For: 1.7.0 > > Attachments: 0001-ACCUMULO-2131-Ensure-source-is-re-checked-for-being-.patch, ACCUMULO-2131.patch > > > Going through PMD output, and this looks a little sketchy in SourceSwitchingIterator.java: > {noformat} > private boolean switchSource() throws IOException { > while (!source.isCurrent()) { > source = source.getNewDataSource(); > iter = source.iterator(); > if (iflag != null) > ((InterruptibleIterator) iter).setInterruptFlag(iflag); > > return true; > } > > return false; > } > {noformat} > I'm wondering if that "while" should be "if" -- This message was sent by Atlassian JIRA (v6.3.4#6332)