accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3761) RowEncodingIterator should take a maximum buffer size parameter
Date Wed, 29 Apr 2015 15:02:07 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519507#comment-14519507
] 

Josh Elser commented on ACCUMULO-3761:
--------------------------------------

Thanks for the patch, [~rweeks]!

{code}
+        kvBufSize += sourceTopKey.getSize() + sourceTopValue.getSize() + 128;
{code}

This was a curious addition that caught my eye. It looks like you copied this from {{TransformingIterator}}
(given [~kturner]'s recommendation on the ML thread). Keith, is this just a constant to account
for general object size overhead?

Otherwise this looks really great! The test case is nice. One nit is that {{testEncodeAll}}
doesn't have the JUnit test annotation, but that's something I can add before commit.

> RowEncodingIterator should take a maximum buffer size parameter
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-3761
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3761
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 1.6.2
>            Reporter: Russ Weeks
>            Assignee: Russ Weeks
>            Priority: Minor
>              Labels: summit2015
>             Fix For: 1.7.0
>
>         Attachments: 0001-ACCUMULO-3761-RowEncodingIterator-should-take-a-maxi.patch
>
>
> It would be nice if the RowEncodingIterator and its subclasses could specify a maximum
buffer size similar to the TransformingIterator.
> Discussion [here|http://www.mail-archive.com/dev%40accumulo.apache.org/msg09821.html]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message