accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3726) Restore MockShell in public API
Date Wed, 15 Apr 2015 18:59:59 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496703#comment-14496703
] 

Josh Elser commented on ACCUMULO-3726:
--------------------------------------

_curse_

I was worried about that. This seems like yet-another-public-api-shouldnt-be-public-api issue.
MockShell came from o.a.a.c.client.mock.MockShell and went to o.a.a.shell.mock.MockShell.
Shell came from o.a.a.core.util.Shell and went to o.a.a.shell.Shell. It makes 0 sense to assume
MockShell is public API but Shell is not (and also causes more problems as it leaks Shell
into the public API).

Given that, I would be in favor of breaking our rules on compatibility.

1. MockShell should never have been in public API (as Shell was never public API)
2. It is not easily restored and deprecated.
3. It is likely very low risk that someone was using themselves (we ourselves only reference
it in a single test case).

cc/ [~busbey] since you have been very adamant in the past on topics of this matter.

> Restore MockShell in public API
> -------------------------------
>
>                 Key: ACCUMULO-3726
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3726
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 1.7.0
>
>
> MockShell was moved from o.a.a.core.client.mock. to o.a.a.shell.mock which is a violation
of our public API statement.
> It needs to be restored and deprecated with a proper cycle.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message