accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3723) TabletServerBatchReaderIterator can eat OOM exceptions
Date Tue, 14 Apr 2015 19:06:36 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494608#comment-14494608
] 

Christopher Tubbs commented on ACCUMULO-3723:
---------------------------------------------

I just did a quick review of our existing code. We do catch {{Error}} in a few places, but
I think we handle it reasonably well in those cases.

The more concerning parts are the catching of {{Throwable}} everywhere. I found around 50
occurrences in our code that catches {{Throwable}} and does little more than log it. In some
cases, we rethrow it, wrapped in a less concerning {{RuntimeException}}, but that practice
might be a bit questionable. Some of these could be replaced with multi-catch blocks with
a narrower set of exceptions.

The most concerning occurrences of catching {{Throwable}} which would affect the client were:

# {{TabletServerBatchReaderIterator}}, as identified above,
# {{TabletServerBatchWriter}}, and
# {{LoggingRunnable}} (which affects a bunch of things in the client)

If somebody takes this issue on, it'd be good to take a quick glance at those other two as
well.

> TabletServerBatchReaderIterator can eat OOM exceptions
> ------------------------------------------------------
>
>                 Key: ACCUMULO-3723
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3723
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.0
>            Reporter: John Vines
>
> Currently in run() it catches Throwable and does no effort to force up catastrophic errors.
In general we shouldn't be catching Throwable unless we know exactly what we're doing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message