accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3652) Remove string concatenation in log statements where slf4j is used.
Date Fri, 10 Apr 2015 17:40:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489982#comment-14489982
] 

Christopher Tubbs commented on ACCUMULO-3652:
---------------------------------------------

JIRA's kinda funny this way:

"Attach Files" is separate from "Submit Patch" (which kinda makes sense, because files can
be attached for many reasons, and not necessarily to represent work done).

To mark as "Patch Available", click "Submit Patch" (it must be assigned to you first, I think,
for this to option to be available). All this does is change the status of the issue. It does
not offer an option to upload a file, so you have to do that in a separate step. If you want
to omit that second step, attaching the patch to a linked review or via a pull request is
sufficient. It's not strictly necessary to attach files to the JIRA in order to mark it as
"Patch Available", but the JIRA should have some link to the pull request or review.

> Remove string concatenation in log statements where slf4j is used.
> ------------------------------------------------------------------
>
>                 Key: ACCUMULO-3652
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3652
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 1.7.0
>            Reporter: Ed Coleman
>            Assignee: Bob Thorman
>            Priority: Minor
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-3652.patch
>
>
> As a separate task, continue with the conversion to remove log4j dependencies, modify
log statements where string concatenation is used and replace with {} parameter substitution.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message