accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3608) Restore backwards binary compatibility with version 1.6.z
Date Tue, 14 Apr 2015 18:55:14 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494591#comment-14494591
] 

Josh Elser commented on ACCUMULO-3608:
--------------------------------------

cc/ [~ctubbsii]

You changed the exceptions throw on the main method in MiniAccumuloRunner from 1.6 to 1.7.
It's throwing more specific exceptions, so I believe it's ok. I just wanted to double check.

{noformat}
commit 8005e82c7ea8599ddbfe4b04e21f1f4dd44b5644
Author: Christopher Tubbs <ctubbsii@apache.org>
Date:   Fri Jan 23 20:32:33 2015 -0500

    ACCUMULO-3514 Use auto-service for start

    Use @AutoService annotations and Java's ServiceLoader mechanism to discover
    classes which are executable by Accumulo's "start" jar with a keyword.

    This replaces manual intervention whenever we add a new option to the
    bin/accumulo script and also auto-populates the usage for that script.

diff --git a/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
b/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
index c45abc0..b727f14 100644
--- a/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
+++ b/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
@@ -136,7 +136,7 @@ public class MiniAccumuloRunner {
    * @param args
    *          An optional -p argument can be specified with the path to a valid properties
file.
    */
-  public static void main(String[] args) throws Exception {
+  public static void main(String[] args) throws IOException, InterruptedException {
     Opts opts = new Opts();
     opts.parseArgs(MiniAccumuloRunner.class.getName(), args);
{noformat}

> Restore backwards binary compatibility with version 1.6.z
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-3608
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3608
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Sean Busbey
>            Priority: Blocker
>             Fix For: 1.7.0
>
>         Attachments: 1.6.2_to_1.7.0_compat_report.html, 1.7.0_to_1.6.2_compat_report.html,
compat_report.html
>
>
> We need to ensure that a check for binary backwards compatibility passes when comparing
1.6.z to current master, since it is only a minor version bump.
> {quote}
> That means new classes, interfaces,methods, enum members, etc are all fine. All of the
things labelled as HIGH severity in the binary compatibility report are definitely a problem.
They're mostly classes and methods that were removed.
> The end goal should be a report like the one Corey got for 1.6.1 -> 1.6.2. We don't
need the reciprocal report to be compatible because minor versions need not be forward compatible.
> Problems in the source compatibility report are worth reviewing, but things that only
show up there shouldn't be a blocker.
> {quote}
> There are instructions for running the compatibility checker in test/compat/japi-compliance/README



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message