accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3608) Restore backwards binary compatibility with version 1.6.z
Date Tue, 14 Apr 2015 18:52:12 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494585#comment-14494585
] 

Keith Turner commented on ACCUMULO-3608:
----------------------------------------

I have a strong suspicion that japi-compliance checker does not consider supertypes based
on the following two tidbits.  However I have not looked at the scripts to confirm this suspicion.

 * We have classes that extent hadoop classes, yet hadoop jars are not req during analysis
 * The japi script uses javap.  javap does not show methods and fields coming from supertypes.
 javap does show supertype name, so its possible that the japi script could make a recursive
call to javap

> Restore backwards binary compatibility with version 1.6.z
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-3608
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3608
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Sean Busbey
>            Priority: Blocker
>             Fix For: 1.7.0
>
>         Attachments: 1.6.2_to_1.7.0_compat_report.html, 1.7.0_to_1.6.2_compat_report.html,
compat_report.html
>
>
> We need to ensure that a check for binary backwards compatibility passes when comparing
1.6.z to current master, since it is only a minor version bump.
> {quote}
> That means new classes, interfaces,methods, enum members, etc are all fine. All of the
things labelled as HIGH severity in the binary compatibility report are definitely a problem.
They're mostly classes and methods that were removed.
> The end goal should be a report like the one Corey got for 1.6.1 -> 1.6.2. We don't
need the reciprocal report to be compatible because minor versions need not be forward compatible.
> Problems in the source compatibility report are worth reviewing, but things that only
show up there shouldn't be a blocker.
> {quote}
> There are instructions for running the compatibility checker in test/compat/japi-compliance/README



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message