accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3608) Restore backwards binary compatibility with version 1.6.z
Date Tue, 14 Apr 2015 19:56:59 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494762#comment-14494762
] 

Josh Elser commented on ACCUMULO-3608:
--------------------------------------

1.7.0->1.6.2

This adds this method to the public API which is likely undesired. It looks like it was used
directly in SimpleMacIT, but my refactoring of SimpleMacIT and ConfigurableMacIT invalidates
this. The method should be made private again.

{noformat}
accumulo-minicluster-1.7.0-SNAPSHOT.jar, MiniAccumuloInstance
package org.apache.accumulo.minicluster
[+] MiniAccumuloInstance.getZooKeepersFromDir ( java.io.File directory ) [static]  :  String
(1) 
{noformat}

The following was added to {{ClientConfiguration}}. I think it's ok, just calling it out as
it's an addition to the public API scope. This was also you, [~billie.rinaldi].

{code}
public Map<String,String> getAllPropertiesWithPrefix(ClientProperty property)
{code}

> Restore backwards binary compatibility with version 1.6.z
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-3608
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3608
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Sean Busbey
>            Priority: Blocker
>             Fix For: 1.7.0
>
>         Attachments: 1.6.2_to_1.7.0_compat_report.html, 1.7.0_to_1.6.2_compat_report.html,
compat_report.html
>
>
> We need to ensure that a check for binary backwards compatibility passes when comparing
1.6.z to current master, since it is only a minor version bump.
> {quote}
> That means new classes, interfaces,methods, enum members, etc are all fine. All of the
things labelled as HIGH severity in the binary compatibility report are definitely a problem.
They're mostly classes and methods that were removed.
> The end goal should be a report like the one Corey got for 1.6.1 -> 1.6.2. We don't
need the reciprocal report to be compatible because minor versions need not be forward compatible.
> Problems in the source compatibility report are worth reviewing, but things that only
show up there shouldn't be a blocker.
> {quote}
> There are instructions for running the compatibility checker in test/compat/japi-compliance/README



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message