accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3604) connector.instanceOperations().setSystemProperty(String,String) returns silently for non-changeable ZK Property's
Date Thu, 30 Apr 2015 21:21:06 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522289#comment-14522289
] 

Christopher Tubbs commented on ACCUMULO-3604:
---------------------------------------------

Thanks for looking at this, [~jschwartz73]. Some feedback on the patch:

* It seems to only apply on 1.7 and later. Is that the desired goal? The ticket is marked
with earlier fixVersions.
* The javadoc description needs a <p> tag before the second paragraph, otherwise it's
going to collapse to the previous sentence (which incidentally, is missing a period).
* Is logging the exception necessary if we're throwing it?
* I'm not sure the statement about "Value is either null" is correct in SystemPropUtil. The
value doesn't appear to be checked for being null at all.
* Would you mind squashing the patch to a single commit? It'd be slightly easier to review/apply.

(Note: if you upload a second patch, please leave the first, for reference, and name the second
*.v2.patch, or similar to indicate it's an updated version.)

Thanks!

> connector.instanceOperations().setSystemProperty(String,String) returns silently for
non-changeable ZK Property's
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3604
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3604
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2
>            Reporter: Josh Elser
>            Assignee: Jeffrey S Schwartz
>              Labels: newbie, summit2015
>             Fix For: 1.5.3, 1.6.3, 1.8.0, 1.7.1
>
>         Attachments: ACCUMULO-3604.patch
>
>
> Only a subset of the configuration {{Property}}'s in Accumulo are modifiable via ZooKeeper
(defined by {{Property.isValidZooProperty}}).
> {{connector.instanceOperations().setProperty(String,String)}} updates the provided property
name with the given value in ZooKeeper. The thing that is never mentioned is that only a subset
of the properties in Accumulo are allowed to be overriden in ZooKeeper. Furthermore, the user
receives no indication that their call failed.
> The Javadoc on {{setSystemProperty(String,String)}} should be updated to inform the users
that only some properties can be changed by this method, and some information should be returned
back to the user to let them know that their call did not succeed (likely an Exception).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message