accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3354) Calling deleteRows on an offline table doesn't include table name in error
Date Thu, 30 Apr 2015 21:36:06 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522311#comment-14522311
] 

Christopher Tubbs commented on ACCUMULO-3354:
---------------------------------------------

Hey, [~meislerj]. Thanks for the patch. Some feedback:

* Careful of trailing whitespace. It will fail the checkstyle part of the build (try running
with {{mvn verify -DskipTests -DskipITs}} to check for findbugs and checkstyle problems without
running the full tests)
* The new constructor for TableOfflineException changes public API, so we can't apply the
change to 1.6.3 or 1.7.1 (but we might be able to sqeeze it into 1.7.0). A solution using
the existing constructor, which takes a tableId, could be applied to earlier versions as a
bug fix, though.
* A very small alternative change might to simply look up the tableId and pass that in the
existing constructor rather than pass null.


> Calling deleteRows on an offline table doesn't include table name in error
> --------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3354
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3354
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.1
>            Reporter: Josh Elser
>            Assignee: Jacob Meisler
>              Labels: newbie, summit2015
>             Fix For: 1.6.3, 1.8.0, 1.7.1
>
>         Attachments: ACCUMULO-3354.patch
>
>
> The table name that I provided to deleteRows should be included in the exception message.
> {noformat}
> org.apache.accumulo.core.client.TableOfflineException: Table  <unknown table> 
is offline
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:333)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:295)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1595)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.deleteRows(TableOperationsImpl.java:557)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message