accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3354) Calling deleteRows on an offline table doesn't include table name in error
Date Wed, 29 Apr 2015 14:45:06 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519465#comment-14519465
] 

Josh Elser commented on ACCUMULO-3354:
--------------------------------------

[~meislerj] it looks like the second file you attached is an addition on top of your original?
Is it possible for you to provide a single diff/patch that incorporates all of your changes?
http://accumulo.apache.org/git.html#contributors might be helpful, but please feel free to
ask questions if it's not obvious how to make Git do what I asked :)

I'm also seeing the following (but I'm not sure entirely sure if it's an issue without trying
to guess at the full picture)

{code}
-          throw new TableOfflineException(instance, null);
+          String tableName = ByteBufferUtil.toString(args.get(0));
+          throw new TableOfflineException(tableName);
{code}

I expected we wouldn't have any more use of {{args.get(0)}}, but please tell me if I'm just
wrong and not seeing the big picture :)

> Calling deleteRows on an offline table doesn't include table name in error
> --------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3354
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3354
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.1
>            Reporter: Josh Elser
>            Assignee: Jacob Meisler
>              Labels: newbie, summit2015
>             Fix For: 1.6.3, 1.8.0, 1.7.1
>
>         Attachments: ACCUMULO-3354, ACCUMULO-3354
>
>
> The table name that I provided to deleteRows should be included in the exception message.
> {noformat}
> org.apache.accumulo.core.client.TableOfflineException: Table  <unknown table> 
is offline
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:333)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:295)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1595)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.deleteRows(TableOperationsImpl.java:557)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message