accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3354) Calling deleteRows on an offline table doesn't include table name in error
Date Wed, 29 Apr 2015 01:14:06 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518507#comment-14518507
] 

Josh Elser commented on ACCUMULO-3354:
--------------------------------------

Thanks for the patch, [~meislerj]. One comment: it appears that in the methods {{offline(String
tableName, boolean wait)}} and {{online(String tableName, boolean wait)}}, {{args.get(0)}}
is actually the table ID, not the table name.

It might be better to push down the table name that's being read from all the way through
{{doFateOperation(FateOperation op, List<ByteBuffer> args, Map<String,String>
opts, boolean wait)}} just so it's crystal clear the table name being operated upon (and doesn't
force us to give good exception messages in multiple places). Thoughts?

> Calling deleteRows on an offline table doesn't include table name in error
> --------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3354
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3354
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.1
>            Reporter: Josh Elser
>            Assignee: Jacob Meisler
>              Labels: newbie, summit2015
>             Fix For: 1.6.3, 1.8.0, 1.7.1
>
>         Attachments: ACCUMULO-3354
>
>
> The table name that I provided to deleteRows should be included in the exception message.
> {noformat}
> org.apache.accumulo.core.client.TableOfflineException: Table  <unknown table> 
is offline
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:333)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:295)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1595)
> 	at org.apache.accumulo.core.client.impl.TableOperationsImpl.deleteRows(TableOperationsImpl.java:557)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message