accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-3331) Dead/invalid code in TabletServer#verifyTabletInformation
Date Mon, 06 Apr 2015 03:10:12 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Elser updated ACCUMULO-3331:
---------------------------------
    Fix Version/s:     (was: 1.7.0)
                   1.7.1
                   1.8.0

> Dead/invalid code in TabletServer#verifyTabletInformation
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-3331
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3331
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.5.2, 1.6.1
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Trivial
>             Fix For: 1.8.0, 1.7.1
>
>
> A couple of things: tabletsKeyValues is passed in but not returned -- the original map
has to be updated, can't assign a new map to the variable otherwise the caller won't see it.
> Additionally, the caller always passes in a new map (never null). We should just assert
that to be non-null. Checking for a non-null map is nonsensical for the previous reason as
well.
> {code}
>     // only populate map after success
>     if (tabletsKeyValues == null) {
>       tabletsKeyValues = tkv;
>     } else {
>       tabletsKeyValues.clear();
>       tabletsKeyValues.putAll(tkv);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message