accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3204) Remove old unused code
Date Mon, 06 Apr 2015 17:16:14 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481447#comment-14481447
] 

Christopher Tubbs commented on ACCUMULO-3204:
---------------------------------------------

I need to review the comments on the patch in ReviewBoard and determine which are safe to
remove now. Some things identified are API and cannot be removed. Some things are safe to
remove now. I'll try to make another pass at this sometime this week. Nothing about this is
a blocker, though, so we can always defer if I cannot get to it.

If somebody else wants to go through the existing patch/comments in ReviewBoard and provide
more targeted patches for specific items which are safe, that's cool, too.

> Remove old unused code
> ----------------------
>
>                 Key: ACCUMULO-3204
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3204
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Minor
>             Fix For: 1.7.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I found a bunch of unused code with UCDetector. Some of this has been introduced recently,
and I've opened issues or commented on the relevant JIRAs for those. However, some of them
are very old, and go back to the initial import to ASF repos.
> These include things like "BulkImportHelper", "BinaryTree", "MasterNotRunningException",
and "EndOfTableException". Some of these were imported with bcfile, but we just don't need
or use. Others are small inner-classes that aren't used any longer. Almost none of them are
documented to explain their existence. These are not API.
> These should all just be cleaned up and removed. Since it's a low priority, I'm not going
to clean anything up prior to 1.7.0
> In addition to the unused classes, there's also some unused methods scattered about.
Those will take longer to identify. If they don't get done by 1.7.0, I'll create a follow-on
task to clean up those.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message