accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3000) Allow use of existing ZK service in MiniAccumuloCluster
Date Tue, 21 Apr 2015 05:00:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504329#comment-14504329
] 

ASF GitHub Bot commented on ACCUMULO-3000:
------------------------------------------

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r28750135
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
    @@ -108,6 +108,19 @@ public MiniAccumuloConfig setZooKeeperStartupTime(long zooKeeperStartupTime)
{
       }
     
       /**
    +   * Configure an existing ZooKeeper instance to use. Calling this method is optional.
If not set, a new ZooKeeper instance is created.
    +   *
    +   * @param existingZooKeepers
    +   *          Connection string for a already-running ZooKeeper instance
    +   *
    +   * @since 1.7.0
    +   */
    +  public MiniAccumuloConfig setExistingZooKeepers(String existingZooKeepers) {
    --- End diff --
    
    > It is, but I don't see a place where we actually leak MiniAccumuloCluster/Config
through that class. Did I miss something?
    
    No, not implying anything leaks.
    
    > If we want to be really picky (and these changes go on the impl), we should not even
expose the new property via MiniAccumuloRunner. Is this what you were pointing to?
    
    Just thinking that if we add it to mini runner, that we will need to continue to support
that option in mini runner.  I think its very similar to adding to API.   I am not opposed
or in favor of adding an option to mini runner or API.  I don't know enough about the performance
impact to have an opinion about adding to API or mini runner.  I am really curious about the
performance impact.   
    



> Allow use of existing ZK service in MiniAccumuloCluster
> -------------------------------------------------------
>
>                 Key: ACCUMULO-3000
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3000
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: mini
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Josh Elser
>            Assignee: Trent Nadeau
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8.0
>
>
> A test harness may have already started ZooKeeper for other testing. MiniAccumuloCluster
could use that same ZooKepeer instance, instead of creating its own, but it is currently not
possible given what MAC does now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message