accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3000) Allow use of existing ZK service in MiniAccumuloCluster
Date Mon, 20 Apr 2015 21:46:59 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503732#comment-14503732
] 

ASF GitHub Bot commented on ACCUMULO-3000:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r28732817
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
    @@ -108,6 +108,19 @@ public MiniAccumuloConfig setZooKeeperStartupTime(long zooKeeperStartupTime)
{
       }
     
       /**
    +   * Configure an existing ZooKeeper instance to use. Calling this method is optional.
If not set, a new ZooKeeper instance is created.
    +   *
    +   * @param existingZooKeepers
    +   *          Connection string for a already-running ZooKeeper instance
    +   *
    +   * @since 1.7.0
    +   */
    +  public MiniAccumuloConfig setExistingZooKeepers(String existingZooKeepers) {
    --- End diff --
    
    MiniAccumuloConfig is in the public API. I'm not sure we want to make this change so outwardly
facing. It might make more sense to only expose it on MiniAccumuloConfigImpl since the primary
use case would be for internal Accumulo testing. Thoughts?


> Allow use of existing ZK service in MiniAccumuloCluster
> -------------------------------------------------------
>
>                 Key: ACCUMULO-3000
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3000
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: mini
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Josh Elser
>            Assignee: Trent Nadeau
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8.0
>
>
> A test harness may have already started ZooKeeper for other testing. MiniAccumuloCluster
could use that same ZooKepeer instance, instead of creating its own, but it is currently not
possible given what MAC does now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message