accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2781) Unit tests should reuse forks by default
Date Fri, 10 Apr 2015 21:41:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490412#comment-14490412
] 

Christopher Tubbs commented on ACCUMULO-2781:
---------------------------------------------

I've narrowed the problem down to one of:

# core/src/test/java/org/apache/accumulo/core/cli/TestClientOpts.java
# core/src/test/java/org/apache/accumulo/core/client/ClientConfigurationTest.java
# core/src/test/java/org/apache/accumulo/core/client/impl/ThriftTransportKeyTest.java
# core/src/test/java/org/apache/accumulo/core/rpc/SaslConnectionParamsTest.java

The problem appears to be the result of one of the SASL tests that set {{ClientProperty.INSTANCE_RPC_SASL_ENABLED}}.
I've not figured out which ones are causing the problem. My suspicion is that the {{SaslConnectionParams}}
constructor is doing work to call Hadoop code which sets some Kerberos configuration state
in Hadoop code. A fix might be to do some of that lazily.

It could also be the static initializer in {{SaslConnectionParams}} which gets the default
realm, since that also calls Hadoop code, and I'm not sure what static JVM state it might
be altering.

> Unit tests should reuse forks by default
> ----------------------------------------
>
>                 Key: ACCUMULO-2781
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2781
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.6.0
>            Reporter: Christopher Tubbs
>             Fix For: 1.8.0
>
>
> The default value for maven-surefire-plugin's reuseForks is true. This is set to false
in our pom.xml in order to keep ITs independent. This inadvertently affects unit tests also,
and causes unit tests to create a new JVM for each test class.
> These should be separated, and the default for unit tests (maven-surefire-plugin's execution)
should be {{reuseForks=true}}, and the default for ITs (maven-failsafe-plugin's execution)
should be {{reuseForks=false}} (as it is now).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message