accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2325) Avoid repeated checking in addViolation in NumericValueConstraint and AlphaNumKeyContraint
Date Mon, 06 Apr 2015 03:20:12 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14480882#comment-14480882
] 

Josh Elser commented on ACCUMULO-2325:
--------------------------------------

I'll try to take a look at this. Sorry for it sitting for so long.

> Avoid repeated checking in addViolation in NumericValueConstraint and AlphaNumKeyContraint
> ------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2325
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2325
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Vikram Srivastava
>            Assignee: Vikram Srivastava
>            Priority: Minor
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2325.v1.patch.txt
>
>
> addViolation is very verbose and does check for null on every violation. Instead we can
initialize violations as non-null just return null from check if the list is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message