Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Sat, 14 Mar 2015 00:30:38 +0000 (UTC)
From: "Ed Coleman (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12640880.1365113057000.91958.1426293038463@Atlassian.JIRA>
In-Reply-To: <JIRA.12640880.1365113057000@Atlassian.JIRA>
References: <JIRA.12640880.1365113057000@Atlassian.JIRA>
 <JIRA.12640880.1365113057056@arcas>
Subject: [jira] [Commented] (ACCUMULO-1242) Consistent logging
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361398#comment-14361398 ] 

Ed Coleman commented on ACCUMULO-1242:
--------------------------------------

Give me a few - I just saw Josh's comment on a pull request about running check-style and I'm running it now and found a few issues - I'll correct those and then submit a "clean" patch.


> Consistent logging
> ------------------
>
>                 Key: ACCUMULO-1242
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1242
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>            Reporter: Christopher Tubbs
>            Assignee: Ed Coleman
>              Labels: log4j, logging, logs, slf4j
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-1242-2.patch, accumulo-slf4j-snapshot.patch, dynamicLog.tgz
>
>
> Logging dependencies are very inconsistent. It seems we have absolute dependencies on log4j, yet use slf4j sometimes, and log4j other times. In some of our tests we have slf4j-nop as a test dependency.
> It seems we could consolidate a lot of this if we simply did:
> # slf4j-api : compile
> # slf4j-log4j12 : runtime
> # slf4j-nop : test
> # log4j : runtime
> We could do this in the parent POM and get rid of all the different dependencies throughout the code.
> I don't know that we could ever use anything other than slf4j-log4j12 as the implementation (unless our dependencies broke away from using log4j directly also), but at least we'd clean up all the logging dependencies in our code/build, and would be ready to switch to something better if something came along. Further, if somebody wanted to reuse our code, and weren't tied to log4j, because they didn't need our transitive dependencies that locked in log4j, they could easily depend on their own slf4j implementation jar, and all the logging in our code would still work correctly for them without needing to use something like log4j-over-slf4j.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)