accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-3644) [FindBugs] DelegationToken.equals() is not symmetric with PasswordToken.equals()
Date Thu, 05 Mar 2015 02:33:38 GMT
Christopher Tubbs created ACCUMULO-3644:
-------------------------------------------

             Summary: [FindBugs] DelegationToken.equals() is not symmetric with PasswordToken.equals()
                 Key: ACCUMULO-3644
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3644
             Project: Accumulo
          Issue Type: Sub-task
          Components: client
            Reporter: Christopher Tubbs
            Assignee: Josh Elser
             Fix For: 1.7.0


FindBugs at rank 8 warns about DelegationToken overriding PasswordToken, but doing so in a
way that makes {{a.equals(b)}} possibly not the same result as {{b.equals(a)}} when one of
them is a DelegationToken and one of them isn't.

I see two fixes:
# ensure that the entirety of what describes DelegationToken are in the bits checked by PasswordToken
and don't override it
# change PasswordToken so that it doesn't consider subclasses to be equal... they must also
be exactly PasswordToken



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message