accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3641) Mark slf4j implementation dependencies "optional"
Date Thu, 19 Mar 2015 00:56:38 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368254#comment-14368254
] 

Josh Elser commented on ACCUMULO-3641:
--------------------------------------

bq. will need to provide their own slf4j implementation if they want logging.

I assume there's no good way we could actually require them to do this? Obviously, they'll
eventually figure it out when they don't have an impl jar on the classpath.

> Mark slf4j implementation dependencies "optional"
> -------------------------------------------------
>
>                 Key: ACCUMULO-3641
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3641
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Christopher Tubbs
>             Fix For: 1.7.0
>
>
> After ACCUMULO-1242 is complete, we should not have any more direct usage of log4j or
any other particular slf4j implementation. As such, we should mark log4j (and any other slf4j
implementations) as optional in the dependencies section of the POM.
> ["Optional" dependencies in Maven|http://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html]
are not automatically inherited transitively when other projects depend on ours. This is important,
because if somebody writes a client application which depends on Accumulo code, we should
not be forcing that application into a particular logging implementation. Marking it optional
is preferable to forcing them to exclude the transitive dependencies in order to provide their
own. It will also prevent conflicts when they have dependencies on other projects, which require
a particular conflicting implementation of slf4j.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message