Return-Path: 
 <notifications-return-27567-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8A93417339
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Thu, 12 Feb 2015 22:13:20 +0000 (UTC)
Received: (qmail 79585 invoked by uid 500); 12 Feb 2015 22:13:12 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 79521 invoked by uid 500); 12 Feb 2015 22:13:12 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 79308 invoked by uid 99); 12 Feb 2015 22:13:12 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Feb 2015 22:13:12 +0000
Date: Thu, 12 Feb 2015 22:13:12 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12774689.1423774228000.32189.1423779192463@Atlassian.JIRA>
In-Reply-To: <JIRA.12774689.1423774228000@Atlassian.JIRA>
References: <JIRA.12774689.1423774228000@Atlassian.JIRA>
 <JIRA.12774689.1423774228831@arcas>
Subject: [jira] [Commented] (ACCUMULO-3585) toString on Array doesn't log
 information as expected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/ACCUMULO-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319102#comment-14319102 ] 

Christopher Tubbs commented on ACCUMULO-3585:
---------------------------------------------

Unless I'm confused and the Integers are for replicas, not sizes? I'd have to go back and look at the actual code, I guess, not the patch.

> toString on Array doesn't log information as expected
> -----------------------------------------------------
>
>                 Key: ACCUMULO-3585
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3585
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.2
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Trivial
>             Fix For: 1.7.0, 1.6.3
>
>
> {noformat}
> > http://git-wip-us.apache.org/repos/asf/accumulo/blob/ac44627e/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> > ----------------------------------------------------------------------
> > diff --git
> > a/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> > b/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> > index 9a54927..24eac05 100644
> > ---
> > a/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> > +++
> > b/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> > @@ -96,7 +96,9 @@ public class TableDiskUsage {
> >      Map<List<Integer>,Long> usage = new HashMap<List<Integer>,Long>();
> >
> >      for (Entry<String,Integer[]> entry : tableFiles.entrySet()) {
> > -      log.info("fileSizes " + fileSizes + " key " +
> > Arrays.asList(entry.getKey()));
> > +      if (log.isTraceEnabled()) {
> > +        log.trace("fileSizes " + fileSizes + " key " + entry.getKey());
> > +      }
> >
> {noformat}
> Caught by [~kturner]
> {quote}
> Arrays usually have completely useless toString() methods.  So going from
> Arrays.asList(entry.getKey()).toString() to entry.getKey().toString().
> will likely not print the Integer[] array contents
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)