Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7709C100FA for ; Wed, 11 Feb 2015 00:56:18 +0000 (UTC) Received: (qmail 90863 invoked by uid 500); 11 Feb 2015 00:56:12 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 90763 invoked by uid 500); 11 Feb 2015 00:56:12 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 90343 invoked by uid 99); 11 Feb 2015 00:56:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Feb 2015 00:56:12 +0000 Date: Wed, 11 Feb 2015 00:56:11 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-3577) VolumeManager FileType needs unit tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315312#comment-14315312 ] Christopher Tubbs commented on ACCUMULO-3577: --------------------------------------------- To be clear, the bug looks like it would appear for any FileType, not just tables. Example: a volume called {{hdfs://nn1/walkerTexasRanger}} in the case of {{/wal}} write-ahead log file types. > VolumeManager FileType needs unit tests > --------------------------------------- > > Key: ACCUMULO-3577 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3577 > Project: Accumulo > Issue Type: Bug > Reporter: Christopher Tubbs > Fix For: 1.7.0, 1.6.3 > > > The FileType enum in VolumeManager has some behavior which should be unit tested. > In particular, it should check that the retrieval (or removal) of volumes from a path works correctly. > At first glance, it looks to me like it is broken, because it is looking for the first occurrence of a directory which starts with {{/tables}}, in the case of tables. However, that will break if the volume itself had a path with {{/tables}} in it (example: {{hdfs://nn1/tablesorting-application/accumulo}}, which would have the directory {{hdfs://nn1/tablesorting-application/accumulo/tables/...}}) -- This message was sent by Atlassian JIRA (v6.3.4#6332)