accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3601) master does not process migrations
Date Fri, 20 Feb 2015 23:51:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329781#comment-14329781
] 

Josh Elser commented on ACCUMULO-3601:
--------------------------------------

I *think* this is necessary. We don't want to return tablets that have migrations which are
destined to be deleted:

{code}
diff --git a/server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateChangeIterator.java
b/server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateChangeIterator.java
index 77b598c..a972d10 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateChangeIterator.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateChangeIterator.java
@@ -160,14 +160,15 @@ public class TabletStateChangeIterator extends SkippingIterator {
         // could make this smarter by only returning if the tablet is involved in the merge
         return;
       }
-      // always return the information for migrating tablets
-      if (migrations.contains(tls.extent)) {
-        return;
-      }

       // is the table supposed to be online or offline?
       boolean shouldBeOnline = onlineTables.contains(tls.extent.getTableId().toString());

+      // always return the information for migrating tablets
+      if (shouldBeOnline && migrations.contains(tls.extent)) {
+        return;
+      }
+
       if (debug) {
         log.debug(tls.extent + " is " + tls.getState(current) + " and should be " + (shouldBeOnline
? "on" : "off") + "line");
       }
{code}

> master does not process migrations
> ----------------------------------
>
>                 Key: ACCUMULO-3601
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3601
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>            Priority: Blocker
>             Fix For: 1.5.3, 1.7.0, 1.6.3
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> While attempting to write a test for ACCUMULO-3597, I found the master was not balancing.
 The iterator that filters the metadata table does not take migrations into account, so the
state of the tablets was never seen, and processed.  This bug was introduced with the fix
to ACCUMULO-3580.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message