accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Dailey (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method
Date Tue, 24 Feb 2015 04:21:11 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Dailey updated ACCUMULO-2817:
----------------------------------
    Attachment: ACCUMULO-2817.patch

New patch rebased against master at commit {{6487e0c}}.  Squashed my branch into one commit
for patch.

Changes:
# Did not edit Replication.java
# StatusCombiner has new decode, but works around Status lacking {{parse(byte[], int, int)}}.
# AbstractEncoder does not catch Preconditions' RuntimeExceptions.
# {{decode(byte[] b)}} _should_ and *does* check null.
# AbstractLexicoder moved to lexicoder.impl package (non-public API)
# Nothing else need {{@since}} tags

> Add offset and limit arguments to byte array Encoder.decode method
> ------------------------------------------------------------------
>
>                 Key: ACCUMULO-2817
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2817
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Josh Elser
>            Assignee: Matt Dailey
>              Labels: newbie
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2817.patch
>
>
> Similar to ACCUMULO-2445, but presently the encoder only works on complete byte arrays.
This forces an extra copy of the data when it is located in an array that contains other information
(e.g. a composite key).
> It would be nice to be able to provide offset and length arguments to {{Encoder.decode}}
so that users can avoid the additional arraycopy.
> Changing to a ByteBuffer instead of byte array argument would also be acceptable, but
more churn on the API that, unless it's happening globally, I would rather avoid. It would
also incur the penalty for that extra Object, which while minimal alone, could be significant
if decoding every value in a table, for example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message