accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method
Date Mon, 23 Feb 2015 19:31:11 GMT


Josh Elser commented on ACCUMULO-2817:

Also, in the future, if you can squash your commits into a single commit in the patch, that'd
be awesome. It makes it a bit easier to consume.

$ git checkout my_branch
$ vim
$ git commit -m 'hacked some more'
$ git checkout -b my_squashed_branch
$ git rebase -i master
  # change 'pick' to 'squash' for all but the first commit
$ git format-patch master

This will result in a git-formatted patch that has just one commit. This lets you still make
many commits in {{my_branch}} and then squash them all together into a single ticket for everyone
else to look at as a whole.

> Add offset and limit arguments to byte array Encoder.decode method
> ------------------------------------------------------------------
>                 Key: ACCUMULO-2817
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Josh Elser
>            Assignee: Matt Dailey
>              Labels: newbie
>             Fix For: 1.7.0
>         Attachments: ACCUMULO-2817.patch
> Similar to ACCUMULO-2445, but presently the encoder only works on complete byte arrays.
This forces an extra copy of the data when it is located in an array that contains other information
(e.g. a composite key).
> It would be nice to be able to provide offset and length arguments to {{Encoder.decode}}
so that users can avoid the additional arraycopy.
> Changing to a ByteBuffer instead of byte array argument would also be acceptable, but
more churn on the API that, unless it's happening globally, I would rather avoid. It would
also incur the penalty for that extra Object, which while minimal alone, could be significant
if decoding every value in a table, for example.

This message was sent by Atlassian JIRA

View raw message