Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8750317A82 for ; Fri, 23 Jan 2015 02:29:34 +0000 (UTC) Received: (qmail 88880 invoked by uid 500); 23 Jan 2015 02:29:34 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 88840 invoked by uid 500); 23 Jan 2015 02:29:34 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 88829 invoked by uid 99); 23 Jan 2015 02:29:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 02:29:34 +0000 Date: Fri, 23 Jan 2015 02:29:34 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-3519) Unused AccumuloSecurityException constructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288625#comment-14288625 ] Christopher Tubbs commented on ACCUMULO-3519: --------------------------------------------- Other exceptions, such as NamespaceNotEmptyException, have similar issues of thrift objects used in their constructors, and they are considered public API. NamespaceNotEmptyException also has an unused constructor. > Unused AccumuloSecurityException constructor > -------------------------------------------- > > Key: ACCUMULO-3519 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3519 > Project: Accumulo > Issue Type: Sub-task > Reporter: Christopher Tubbs > Fix For: 1.7.0 > > > AccumuloSecurityException has a public constructor which is completely unused. I don't know if we should consider constructors of exceptions "public API", but they are defined as such in the README, so a strict interpretation is that they are. > The unused constructor in question is: > {code}public AccumuloSecurityException(final String user, final SecurityErrorCode errorcode, final String tableInfo) { ... }{code} > This class also uses thrift objects in its constructors, which we don't consider public API, so either we should also consider constructors of exceptions to be *not* public API (in which case, we can just delete the unused constructor), or we should consider the use of thrift objects bugs. > If these constructors are public API, they should have tests and we shouldn't have any unused (because they would minimally be referenced in tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332)