accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <>
Subject [jira] [Updated] (ACCUMULO-3519) Unused AccumuloSecurityException constructor
Date Fri, 23 Jan 2015 01:49:34 GMT


Christopher Tubbs updated ACCUMULO-3519:
    Summary: Unused AccumuloSecurityException constructor  (was: Unused AccumuloSecurityException

> Unused AccumuloSecurityException constructor
> --------------------------------------------
>                 Key: ACCUMULO-3519
>                 URL:
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Christopher Tubbs
>             Fix For: 1.7.0
> AccumuloSecurityException has a public constructor which is completely unused. I don't
know if we should consider constructors of exceptions "public API", but they are defined as
such in the README, so a strict interpretation is that they are.
> The unused constructor in question is:
> {code}public AccumuloSecurityException(final String user, final SecurityErrorCode errorcode,
final String tableInfo) { ... }{code}
> This class also uses thrift objects in its constructors, which we don't consider public
API, so either we should also consider constructors of exceptions to be *not* public API (in
which case, we can just delete the unused constructor), or we should consider the use of thrift
objects bugs.
> If these constructors are public API, they should have tests and we shouldn't have any
unused (because they would minimally be referenced in tests).

This message was sent by Atlassian JIRA

View raw message