accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-3496) ZooKeeperInstance doesn't validate instance name on creation
Date Mon, 19 Jan 2015 17:38:34 GMT
Josh Elser created ACCUMULO-3496:
------------------------------------

             Summary: ZooKeeperInstance doesn't validate instance name on creation
                 Key: ACCUMULO-3496
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3496
             Project: Accumulo
          Issue Type: Bug
          Components: client
    Affects Versions: 1.6.1, 1.6.0
            Reporter: Josh Elser
            Assignee: Josh Elser
            Priority: Blocker
             Fix For: 1.6.2, 1.7.0


ZooKeeperInstance in 1.5 contained a check when the instance name was used to ensure that
a real instanceName was provided.

{code}
 public ZooKeeperInstance(String instanceName, String zooKeepers, int sessionTimeout) {
     ArgumentChecker.notNull(instanceName, zooKeepers);
     this.instanceName = instanceName;
     this.zooKeepers = zooKeepers;
     this.zooKeepersSessionTimeOut = sessionTimeout;
     zooCache = ZooCache.getInstance(zooKeepers, sessionTimeout);
     getInstanceID();
   }
{code}

The call to {{getInstanceID()}} throws an exception if the instanceName didn't exist in ZK.

In 1.6, this check no longer exists and will only happen when the ZKI is actually used (typically
on getConnector(...)).

Restore the check when the instance name is provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message