Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6889510527 for ; Wed, 17 Dec 2014 00:47:14 +0000 (UTC) Received: (qmail 65410 invoked by uid 500); 17 Dec 2014 00:47:14 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 65376 invoked by uid 500); 17 Dec 2014 00:47:14 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 65337 invoked by uid 99); 17 Dec 2014 00:47:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Dec 2014 00:47:14 +0000 Date: Wed, 17 Dec 2014 00:47:14 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ACCUMULO-3425) Clean up Thrift client/server factory classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249217#comment-14249217 ] Josh Elser edited comment on ACCUMULO-3425 at 12/17/14 12:46 AM: ----------------------------------------------------------------- Transitioning heavier to HostAndPort is drifting up into the client impl, so I'm going to push that to ACCUMULO-3428 was (Author: elserj): Transitioning heavier to HostAndPort is drifting up into the client impl, so I'm going to push that to its own issue. > Clean up Thrift client/server factory classes > --------------------------------------------- > > Key: ACCUMULO-3425 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3425 > Project: Accumulo > Issue Type: Improvement > Components: rpc > Reporter: Josh Elser > Assignee: Josh Elser > Fix For: 1.7.0 > > Time Spent: 40m > Remaining Estimate: 0h > > ThriftUtil (in core) and TServerUtils (in server-base) could both stand to use a general cleanup (as I found in working on ACCUMULO-2815). > * Whitespace > * Ensure client/server logic separation (ThriftUtil/TServerUtils, respectively) > * Any Javadoc > * Switch over to slf4j loggers for better logging without excessive string creation concerns -- This message was sent by Atlassian JIRA (v6.3.4#6332)