Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Mon, 15 Dec 2014 18:21:14 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12725797.1404755946000.25383.1418667674462@Atlassian.JIRA>
In-Reply-To: <JIRA.12725797.1404755946000@Atlassian.JIRA>
References: <JIRA.12725797.1404755946000@Atlassian.JIRA>
 <JIRA.12725797.1404755946013@arcas>
Subject: [jira] [Commented] (ACCUMULO-2981) Cease use of underscore "_" as
 an identifier
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246955#comment-14246955 ] 

Christopher Tubbs commented on ACCUMULO-2981:
---------------------------------------------

[~mdrob] wrote:

bq. Why are we using a character that is difficult to type on traditional keyboards? What's wrong with T/F if we still want single character labels.

The underscore character was originally chose explicitly to make the table which documents the state change operations more readable. I chose a Unicode character which is just as valid as any other character in Java, which preserved the original readability intentions. I did try T/F and _X/__, but this choice looked the best to me. This character's usage is isolated to the array initialization, and should have minimal impact on future development.

If you think another combination would be better, please feel free to change the variable name to your preferred character(s).

bq. Also, there were a bunch of other changes in here that should have been their own issue.

The only other changes in this commit were a type safety check of a generic method which prevented compilation on JDK8, and a change to the POM to make it easier for me to run a test build against 1.8. I wouldn't consider those two "a bunch". They were the minimum changes I needed to make in order to actually test the change. They're also pretty trivial. If you have an objection to either of those changes, feel free to open a new issue.


> Cease use of underscore "_" as an identifier
> --------------------------------------------
>
>                 Key: ACCUMULO-2981
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2981
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>              Labels: newbie
>             Fix For: 1.6.2, 1.7.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JDK 8 adds a new warning that the use of underscore as an identifier may be removed in future versions. We should just go ahead and remove the use of these in our code to eliminate these warnings and prepare for future versions of Java where support for this is dropped.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)