accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3005) Convert the monitor into a real REST server
Date Wed, 03 Dec 2014 01:24:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232429#comment-14232429
] 

Christopher Tubbs commented on ACCUMULO-3005:
---------------------------------------------

Yes, I meant multiple maven modules. I think ideally, there'd be a maven module with the POJOs
and resources and stuff (the "library"; technically, this could be server-base), and then
a separate module for each supported service (embedded jetty launcher, war packaging, tomcat-specific
support).

When I say "I just don't know that we need... right now...", I'm mainly expressing my dislike
of the monitor being part of the core project (as well as the fact that we haven't really
discussed multiple modules in terms of the future of the monitor). I *think* that I'd much
rather prefer all the monitor be a client-only service which simply talks to Accumulo's metrics
API and displays it conveniently. That way, we can separate out the service as a truly separate
thing (modules and all), but which could also just as easily be swapped out for another monitoring
service, if desired. Until things get to that point, I think I'd rather just stick with a
single, convenient module which launches the service in one way (embedded Jetty). *Maybe*
it could also build a generic WAR package for deployment in a separate container, but I wouldn't
want to see a lot of heavyweight refactoring support for the monitor as it exists in the core
project. I'd rather see work to make it replaceable and moved to its own contrib repo, with
support for additional containers supported in separate modules there.

However, I place emphasis on the "don't know" part of my comment, because I think additional
thought needs to be put into this (including reviewing on my part of patches/contributions).

> Convert the monitor into a real REST server
> -------------------------------------------
>
>                 Key: ACCUMULO-3005
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3005
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: monitor
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.7.0
>
>         Attachments: 0001-ACCUMULO-3005-Initial-round-of-changes-for-a-proper-.patch
>
>
> The monitor works well for what it does, but it's very much so cobbled together. HTML
is hand generated. Static state is used liberally which makes testing near impossible. View
and controller logic are tightly intertwined which also adds to the testability problem.
> I've been working on porting the functionality from the existing monitor to a proper
rest service using [dropwizard|https://dropwizard.github.io/dropwizard/]. It's not completely
functional yet, but it has a number of improvements of the existing monitor code.
> I thought I would post what I have already and let people give some feedback if they're
interested. Help is always welcome. https://github.com/joshelser/accumulo/tree/dropwizard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message