accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2659) Incompatible API changes in 1.6.0
Date Thu, 11 Dec 2014 23:34:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243356#comment-14243356
] 

Christopher Tubbs commented on ACCUMULO-2659:
---------------------------------------------

So, I took at a look at the merge commit in question. What it looks like happened is that
these methods had already been dropped in a previous commit, after we had branched 1.6.0 from
master to prepare for release. So, that drop was merged forward to master. This issue (ACCUMULO-2659)
was intended to re-introduce them to 1.6.0 in a deprecated state, so that we'd have a smooth
transition. Merging the commit to master, which re-added these methods, necessarily dropped
them (effectively, a "git merge -s ours 1.6.0-SNAPSHOT" in master, although I doubt that command
was precisely what was used.). So, it only looks like the merge dropped them, but really,
the merge simply didn't re-add them to master, where they already had been dropped.

Also, fixes to 1.6.0 are assumed to be also fixed in future versions, so 1.7.0 fixVersion
isn't needed here. If something regressed in 1.7.0, or we have additional goals to keep these
in for 1.7.0, that should go in a separate issue for 1.7.0 specifically.

> Incompatible API changes in 1.6.0
> ---------------------------------
>
>                 Key: ACCUMULO-2659
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2659
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Keith Turner
>            Assignee: Christopher Tubbs
>            Priority: Blocker
>             Fix For: 1.6.0
>
>
> While examining API changes for 1.6.0 I noticed some non-deprecated methods were removed.
 I am not sure how important these are, but technically these methods are in the public API.
 Opening this issue to document what I found.
> I compared 1.6.0 to 1.5.0.
> In ACCUMULO-1674 the following methods were removed
> {noformat}
> package org.apache.accumulo.core.client.mapreduce.lib.util
> ConfiguratorBase.getToken ( Class<?>, Configuration ) [static]  :  byte[ ]
> ConfiguratorBase.getTokenClass ( Class<?> ,Configuration) [static]  :  String
> {noformat}
> In ACCUMULO-391 the following method was removed
> {noformat}
> package org.apache.accumulo.core.client.mapreduce.lib.util
> InputConfigurator.getTabletLocator ( Class<?>, Configuration ) [static]  : TabletLocator

> {noformat}
> In ACCUMULO-391 the following method was removed and not properly fixed in ACCUMULO-2586
> {noformat}
> accumulo-core.jar, RangeInputSplit.class
> package org.apache.accumulo.core.client.mapred
> InputFormatBase.RangeInputSplit.InputFormatBase.RangeInputSplit ( String table, Range
range, String[ ] locations )
> package org.apache.accumulo.core.client.mapreduce
> InputFormatBase.RangeInputSplit.InputFormatBase.RangeInputSplit ( String table, Range
range, String[ ] locations ) 
> {noformat}
>  It seems like the following were removed in ACCUMULO-1854 
> {noformat}
> package org.apache.accumulo.core.client.mapred
> InputFormatBase.RecordReaderBase<K.setupIterators (JobConf job, Scanner scanner )
 :  void
> package org.apache.accumulo.core.client.mapreduce
> InputFormatBase.RecordReaderBase<K.setupIterators (TaskAttemptContext context, Scanner
scanner)  :  void
> {noformat}
> In ACCUMULO-1018 the following method was removed
> {noformat}
> package org.apache.accumulo.core.client
> MutationsRejectedException.MutationsRejectedException ( List, HashMap, Set, Collection,
int cause, Throwable cvsList ) 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message